Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump fgpyo to ^1.0.0 #125

Merged
merged 3 commits into from
Feb 13, 2025
Merged

chore: Bump fgpyo to ^1.0.0 #125

merged 3 commits into from
Feb 13, 2025

Conversation

msto
Copy link
Collaborator

@msto msto commented Feb 13, 2025

We have a client repository depending on the dev branch of prymer, and this pin is causing some dependency conflicts.

The pinned commit is on the main branch of fgpyo, so I think it's safe to move to a version pin instead.

@msto msto requested review from nh13 and tfenne as code owners February 13, 2025 16:48
@msto msto self-assigned this Feb 13, 2025
.github/workflows/tests.yml Outdated Show resolved Hide resolved
@msto
Copy link
Collaborator Author

msto commented Feb 13, 2025

Tests are currently failing because local poetry locked to numpy=2.2.3, which came out half an hour ago, and GHA poetry can't find the new version yet.

And, afaict, there's no way to give poetry a constraint at the command line (e.g. to create a lockfile with numpy at 2.22.2).

python-poetry/poetry#2758

We just have to wait for the cache to refresh 😞

@msto msto force-pushed the msto-patch-1 branch 3 times, most recently from 246feb5 to fc13ea2 Compare February 13, 2025 17:29
@msto
Copy link
Collaborator Author

msto commented Feb 13, 2025

For posterity, this thread helped me resolve the issue:

python-poetry/poetry#8139

These failures may occur when the local lock file was created before PyPI completed generating all the wheels for a package version. Waiting a bit and then re-generating the lock file was sufficient to resolve.

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.96%. Comparing base (b86dbcd) to head (161fc7e).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #125   +/-   ##
=======================================
  Coverage   94.96%   94.96%           
=======================================
  Files          16       16           
  Lines        1411     1411           
  Branches      161      161           
=======================================
  Hits         1340     1340           
  Misses         49       49           
  Partials       22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msto msto merged commit 9fcb508 into dev Feb 13, 2025
5 checks passed
@msto msto deleted the msto-patch-1 branch February 13, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants