-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fix publishing workflow #123
Conversation
@nh13 is there an effective way to test this short of tagging another release? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #123 +/- ##
=======================================
Coverage 96.81% 96.81%
=======================================
Files 26 26
Lines 1789 1789
Branches 215 215
=======================================
Hits 1732 1732
Misses 31 31
Partials 26 26 ☔ View full report in Codecov by Sentry. |
WalkthroughThe pull request updates a GitHub Actions workflow. It adds a comment explaining a temporary configuration related to the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/publish_prymer.yml (2)
16-21
: Track temporary fix removal.This is a temporary workaround. Create an issue to track the removal of this configuration once rickstaa/action-contains-tag#18 is merged and released.
Want me to create a tracking issue?
22-22
: Remove trailing space.Line has trailing whitespace.
- +🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 22-22: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/publish_prymer.yml
(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
.github/workflows/publish_prymer.yml
[error] 22-22: trailing spaces
(trailing-spaces)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Tests (3.12)
- GitHub Check: Tests (3.11)
Summary
Copies the fix referenced in rickstaa/action-contains-tag#18 and implemented in pybwa
https://github.com/fulcrumgenomics/pybwa/blob/9193fb98fdebf63ed264fa08667b4dbbf79c796c/.github/workflows/publish_pybwa.yml#L16-L22