Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump fgpyo to 1.0 #120

Merged
merged 1 commit into from
Feb 12, 2025
Merged

chore: Bump fgpyo to 1.0 #120

merged 1 commit into from
Feb 12, 2025

Conversation

msto
Copy link
Collaborator

@msto msto commented Feb 12, 2025

No description provided.

@msto msto requested review from nh13 and tfenne as code owners February 12, 2025 20:24
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.81%. Comparing base (aa21269) to head (03cf842).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #120   +/-   ##
=======================================
  Coverage   96.81%   96.81%           
=======================================
  Files          26       26           
  Lines        1789     1789           
  Branches      215      215           
=======================================
  Hits         1732     1732           
  Misses         31       31           
  Partials       26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

coderabbitai bot commented Feb 12, 2025

Walkthrough

The change updates the pyproject.toml file of the prymer project by modifying the dependency version for fgpyo from ^0.8.0 to ^1.0.0. No further changes to dependencies or configurations were made.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9cb2348 and 03cf842.

⛔ Files ignored due to path filters (1)
  • poetry.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Tests (3.12)
  • GitHub Check: Tests (3.11)
🔇 Additional comments (2)
pyproject.toml (2)

40-40: Run comprehensive tests.

Major version bump requires thorough testing.

✅ Verification successful

🏁 Script executed:

#!/bin/bash
# Check test coverage for fgpyo imports
rg -l 'import.*fgpyo|from.*fgpyo' tests/

Length of output: 292


Tests for fgpyo confirmed across multiple modules.

  • Test files in tests/api, tests/offtarget, and tests/primer3 reference fgpyo.
  • Ensure full test suite runs successfully before accepting the major version bump.

40-40: Verify fgpyo 1.0.0 compatibility and security.

Major version bump. Check compatibility and security.

❌ Verification inconclusive

🏁 Script executed:

#!/bin/bash
# Check PyPI for latest versions and release date
curl -s https://pypi.org/pypi/fgpyo/json | jq '.info.version, .releases["1.0.0"].upload_time'

# Check for security advisories
gh api graphql -f query='
{
  securityVulnerabilities(first: 5, ecosystem: PIP, package: "fgpyo") {
    nodes {
      advisory {
        summary
        severity
        publishedAt
      }
      vulnerableVersionRange
    }
  }
}'

Length of output: 458


🌐 Web query:

What are the breaking changes in fgpyo 1.0.0 compared to 0.8.0?

💡 Result:

The provided search results do not contain specific information about breaking changes in fgpyo 1.0.0 compared to 0.8.0. The available sources ([7][8]) focus on general setup instructions, dependencies (Python 3.9+), and development workflows using Poetry, but they do not document version-specific changes or migrations between these releases.

For detailed release notes or breaking changes in fgpyo, you would need to consult the project’s official changelog, GitHub releases page, or commit history directly—none of which are included in the provided search results.

Citations:


Verify fgpyo 1.0.0 compatibility and security.

  • PyPI confirms the latest version is 1.0.0 and no security advisories were found.
  • Web searches did not reveal documented breaking changes from 0.8.0 to 1.0.0.
  • Given the major version bump, review the official changelog/GitHub releases and conduct comprehensive tests to catch any latent issues.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@msto
Copy link
Collaborator Author

msto commented Feb 12, 2025

@nh13 if we merge this could it be accompanied by a 3.0.1 release?

I think a patch bump is appropriate based on this comment: semver/semver#148 (comment)

@msto msto merged commit a1f82ed into main Feb 12, 2025
7 checks passed
@msto msto deleted the ms_bump-fgpyo branch February 12, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants