HDFS-17449. Fix ill-formed decommission host name and port pair trigg…

…ers IndexOutOfBound error (apache#6691). Contributed by ConfX Signed-off-by: Ayush Saxena <[email protected]>
fuchaohong · Apr 6, 2024 · 73e6931 · 73e6931
1 parent a1ae35e
commit 73e6931
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/...p-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/util/HostsFileWriter.java b/...p-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/util/HostsFileWriter.java
@@ -106,6 +106,10 @@ public void initOutOfServiceHosts(List<String> decommissionHostNameAndPorts,
         for (String hostNameAndPort : decommissionHostNameAndPorts) {
           DatanodeAdminProperties dn = new DatanodeAdminProperties();
           String[] hostAndPort = hostNameAndPort.split(":");
+          if (hostAndPort.length != 2) {
+            throw new IllegalArgumentException("The decommision host name and port format is "
+                + "invalid. The format should be in <host>:<port>, not " + hostNameAndPort);
+          }
           dn.setHostName(hostAndPort[0]);
           dn.setPort(Integer.parseInt(hostAndPort[1]));
           dn.setAdminState(AdminStates.DECOMMISSIONED);