Updates to DList #584
Merged
Updates to DList #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gusty
force-pushed
the
gus/dlist-update
branch
4 times, most recently
from
aee396c to
6ead245
Compare
gusty
force-pushed
the
gus/dlist-update
branch
from
8375be0 to
857a300
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is a bit old and is claiming for some attention.
Also it's important to note there are some false statements in the comments: walking the DList is not O(n) but O(2n).
The advantage of DList is that it can add and also append lists in O(1), whereas append for other collections is slower.