Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add _internal/delete_all to delete all data #1833

Merged
merged 3 commits into from
Jan 5, 2025
Merged

feat: Add _internal/delete_all to delete all data #1833

merged 3 commits into from
Jan 5, 2025

Conversation

drehelis
Copy link
Contributor

@drehelis drehelis commented Nov 30, 2024 •
edited by fsouza
Loading

Closes #1828.

@drehelis drehelis changed the title feat: Add to delete all data feat: Add _internal/delete_all to delete all data Nov 30, 2024
@drehelis
Copy link
Contributor Author

@fsouza ping?

@fsouza
Copy link
Owner

fsouza commented Dec 13, 2024

@drehelis sorry things have been slow on my end, but I'm planning to dedicate some time to fake-gcs-server this weekend!

@drehelis
Copy link
Contributor Author

@fsouza how 'bout it?

fsouza
fsouza reviewed Jan 4, 2025
View reviewed changes
Copy link
Owner

@fsouza fsouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, but I think it makes more sense to have the operation in the backend interface and just forward it from the HTTP handler.

fakestorage/server.go Outdated Show resolved Hide resolved
fsouza
fsouza approved these changes Jan 5, 2025
View reviewed changes
Copy link
Owner

@fsouza fsouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fsouza fsouza merged commit c9ce436 into fsouza:main Jan 5, 2025
42 checks passed
@drehelis drehelis deleted the delete_all branch January 5, 2025 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsouza fsouza fsouza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature req] _internal/delete_all endpoint
2 participants
@drehelis @fsouza