Propagate ContentType field on create/modify ops #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit tries to address 2 bugs that where found when using some of the create/modify operations GCS supports like: * using the streamable upload operations of GCS to upload of a File. * update the blob metadata content-type without modifying the bytes of the blob. For the streamable upload, by default if no content-type is provided; GCS sets it up to 'application/octet-stream' or uses the one provided by the user in the BlobInfo (This is the expected behaviour for this operation in GCS). For the update, when we merge metadata information regarding the content-type, it should override it the update response should propagate this change.
|
@fsouza Hey! 👋 Please review when you have time! 🙏 |
fsouza
reviewed
May 2, 2023
This adds a unit test to check that when calling the updateObject method and a content type is provided, we override the previous value stored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to address 2 bugs that where found when using some of the create/modify operations GCS supports in our integration tests that used the following interactions:
To crosscheck, we ran the same tests against the real GCS API to verify the behaviour to expect:
content-typeis provided; GCS sets it up to'application/octet-stream'or uses the one provided by the user in the BlobInfo (This is the expected behaviour for this operation in GCS).Also this behaviour is referenced on the API spec, that the
content-typeshould be set toapplication/octet-streamon object creation if it is not defined:Also should hopefully address the following issue #1098 🙂
Fixes #1098.