Add support for MaxResults when listing objects

fsouza · Nov 26, 2024 · 9afbb8a · 9afbb8a
1 parent 9e26890
commit 9afbb8a
Showing 1 changed file with 13 additions and 0 deletions.
diff --git a/fakestorage/object.go b/fakestorage/object.go
@@ -315,6 +315,7 @@ type ListOptions struct {
 	StartOffset              string
 	EndOffset                string
 	IncludeTrailingDelimiter bool
+	MaxResults               int
 }
 
 // ListObjects returns a sorted list of objects that match the given criteria,
@@ -365,6 +366,9 @@ func (s *Server) ListObjectsWithOptions(bucketName string, options ListOptions)
 		respPrefixes = append(respPrefixes, p)
 	}
 	sort.Strings(respPrefixes)
+	if options.MaxResults != 0 && len(respObjects) > options.MaxResults {
+		respObjects = respObjects[:options.MaxResults]
+	}
 	return respObjects, respPrefixes, nil
 }
 
@@ -557,13 +561,22 @@ func (s *Server) objectWithGenerationOnValidGeneration(bucketName, objectName, g
 
 func (s *Server) listObjects(r *http.Request) jsonResponse {
 	bucketName := unescapeMuxVars(mux.Vars(r))["bucketName"]
+	var maxResults int
+	var err error
+	if maxResultsStr := r.URL.Query().Get("maxResults"); maxResultsStr != "" {
+		maxResults, err = strconv.Atoi(maxResultsStr)
+		if err != nil {
+			return jsonResponse{status: http.StatusBadRequest}
+		}
+	}
 	objs, prefixes, err := s.ListObjectsWithOptions(bucketName, ListOptions{
 		Prefix:                   r.URL.Query().Get("prefix"),
 		Delimiter:                r.URL.Query().Get("delimiter"),
 		Versions:                 r.URL.Query().Get("versions") == "true",
 		StartOffset:              r.URL.Query().Get("startOffset"),
 		EndOffset:                r.URL.Query().Get("endOffset"),
 		IncludeTrailingDelimiter: r.URL.Query().Get("includeTrailingDelimiter") == "true",
+		MaxResults:               maxResults,
 	})
 	if err != nil {
 		return jsonResponse{status: http.StatusNotFound}