chore: upgrade deps, improve type hints and check style in ci #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waketzheng
commented
Feb 26, 2025
|
@frostming Cloud you review this? |
frostming
reviewed
Mar 10, 2025
| @@ -52,6 +52,10 @@ jobs: | |||
|
|
|||
| - name: Install packages | |||
| run: pdm install | |||
| - name: Check Style | |||
There was a problem hiding this comment.
Instead of calling pip with pdm run, which is not recommended, you should add pre-commit into dev dependencies and install from that group.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pdm updatepdm run pre-commit run --all-filesand add this command to ci