chore: update github action versions

Signed-off-by: Frost Ming <[email protected]>
frostming · Mar 25, 2024 · 3d813d0 · 3d813d0
1 parent d91c2cd
commit 3d813d0
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 11 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -24,9 +24,9 @@ jobs:
             arch: x86
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: Set up PDM
-        uses: pdm-project/setup-pdm@v3
+        uses: pdm-project/setup-pdm@v4
         with:
           python-version: ${{ matrix.python-version }}
           architecture: ${{ matrix.arch }}

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -11,12 +11,12 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 0
-      - uses: actions/setup-node@v3
+      - uses: actions/setup-node@v4
         with:
-          node-version: 16
+          node-version: 20
 
       - run: npx changelogithub
         continue-on-error: true
@@ -27,8 +27,7 @@ jobs:
           python-version: "3.10"
       - name: Build artifacts
         run: |
-          pip install build
-          python -m build
+          pipx run build
       - name: Test Build
         run: |
           python -m venv fresh_env
@@ -37,5 +36,4 @@ jobs:
           findpython --all
       - name: Upload to Pypi
         run: |
-          pip install twine
-          twine upload --username __token__ --password ${{ secrets.PYPI_TOKEN }} dist/*
+          pipx run twine upload --username __token__ --password ${{ secrets.PYPI_TOKEN }} dist/*
diff --git a/src/findpython/providers/winreg.py b/src/findpython/providers/winreg.py
@@ -35,10 +35,10 @@ def find_pythons(self) -> t.Iterable[PythonVersion]:
             except AttributeError:
                 continue
             if path.exists():
-                version = getattr(version.info, "version", None)
+                py_version = getattr(version.info, "version", None)
                 py_ver = self.version_maker(
                     path,
-                    Version(version) if version else None,
+                    Version(py_version) if py_version else None,
                     getattr(version.info, "sys_architecture", SYS_ARCHITECTURE),
                     path,
                 )