Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PostgreSQL #56

Merged
merged 6 commits into from
Sep 1, 2023
Merged

PostgreSQL #56

merged 6 commits into from
Sep 1, 2023

Conversation

friendbear
Copy link
Owner

issue #50

@friendbear friendbear added the learning Books and other studies label Sep 1, 2023
@friendbear friendbear self-assigned this Sep 1, 2023
friendbear
friendbear commented Sep 1, 2023
View reviewed changes
Copy link
Owner Author

@friendbear friendbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore の理由を統一すること。

practice_collection/postgresql/src/tokio_connect.rs
eprintln!("Connection error: {}", e);
}
});
//handle.await.expect("Async task panicked");
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

async functionの中で tokio::spawn のJoinHandlerをawaitしてはならない。

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@friendbear friendbear merged commit 2684dde into main Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@friendbear friendbear

Labels
learning Books and other studies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@friendbear