Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset editor when closing the window. fix #30 fix #29 #32

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

j-levy
Copy link
Collaborator

@j-levy j-levy commented Jun 15, 2021

Even though it deletes and re-creates the editor object, it's a simple enough fix for now.
I also fixed the window size starting too small on macOS 11.4 (now it starts at a comfortable 600x400 with a strict minimum size of 300x200, so you don't get lost with a dialog you can't even see the content of)

@j-levy
Copy link
Collaborator Author

j-levy commented Jun 16, 2021

Note: travis builds fail because of a problem in their configuration, I think
If I see the logs, it ends like this:


export PATH='/Users/travis/miniconda/bin:/Users/travis/miniconda/condabin:/Users/travis/miniconda/bin:/Users/travis/.rvm/gems/ruby-2.6.3/bin:/Users/travis/.rvm/gems/ruby-2.6.3@global/bin:/Users/travis/.rvm/rubies/ruby-2.6.3/bin:/Users/travis/.rvm/bin:/Users/travis/bin:/Users/travis/.local/bin:/Users/travis/.nvm/versions/node/v13.0.1/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/opt/X11/bin'

export CONDA_SHLVL='1'

export CONDA_PROMPT_MODIFIER='(base) '

Traceback (most recent call last):

  File "release.py", line 15, in <module>

    for job in status['jobs'][:TRAVIS_JOB_NUMBER]:

KeyError: 'jobs'

Note 2: tested and working on Windows 10 21H1 too.

@j-levy
Copy link
Collaborator Author

j-levy commented Jun 17, 2021

I also fixed the crash on windows in issue #29

@j-levy j-levy changed the title reset editor when closing the window. fix #30 reset editor when closing the window. fix #30 fix #29 Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant