feature: Make sidebar items' links full-width #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #254 ↗︎
Details:
Review all test suite changes for PR #197 ↗︎ |
|||||||||||||||
BreadGenie
reviewed
Nov 22, 2023
BreadGenie
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the hopes of fixing #196
I only added
width: 100%to CSS selector.sidebar-item :first-childto expand the child<a>element.This make the sidebar links consistent with the sidebar groups which are full-width as well as making it easier to navigate through the pages without having to think how long the title is.
I left the
margin-right: auto, but by making thewidth: 100%, it removes the margin. There may be a situation where it is needed, but it seems very unlikely.