perf(build): Reduce gzip compression level in packaging build context #2400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- By default, tarfile library do gzip compression at 9 level - Anything above 5 or 6 can take significant resource and time - Based on tests, result of compression of 10 frappe apps around 430MB - With compression level 5, it takes ~8.5s and compressed file size 239MB - With compress level 9, it takes ~13.5s and compressed file size 235MB So, we are not getting too much benefit from using compression level 9
Usually in macos, we have different uid/gid than any linux system So, in development, it was causing issue. That's why the permission modification was added - frappe#1925 But, in prod it's not required. So, we can just modify permission, when developer mode is enabled
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2400 +/- ##
==========================================
- Coverage 38.33% 38.33% -0.01%
==========================================
Files 378 378
Lines 29534 29536 +2
==========================================
Hits 11322 11322
- Misses 18212 18214 +2 ☔ View full report in Codecov by Sentry. |
|
@tanmoysrt you might wanna add all existing violations to cspell whitelist in one shot, else it will become a continuous annoyance and won't help much. |
Added those words in whitelist. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, tarfile library in python do gzip compression at level 9 (ref).
tarorgzipcli use compress level 6 by default (ref).Anything above 5 or 6 compression level can take significant resource and time.
Locally, I have cloned 10 frappe apps (430MB) to compress with different gzip level using tarfile.
Other benchmarks - https://stephane.lesimple.fr/blog/lzop-vs-compress-vs-gzip-vs-bzip2-vs-lzma-vs-lzma2xz-benchmark-reloaded/