Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bench): Add field to allow configuring custom redis memory limit #2388

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

tarunps
Copy link
Member

@tarunps tarunps commented Dec 27, 2024

Closes #1386
Adds a field in Press Settings, Deploy Candidate and Release Group to allow configuring custom redis cache size

@tarunps tarunps force-pushed the feat/custom-redis-mem-size branch from d4654a5 to 7aa40dd Compare December 27, 2024 08:19
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 38.52%. Comparing base (65b8ad7) to head (b530508).

Files with missing lines Patch % Lines
press/press/doctype/release_group/release_group.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2388   +/-   ##
=======================================
  Coverage   38.52%   38.52%           
=======================================
  Files         377      377           
  Lines       29286    29288    +2     
=======================================
+ Hits        11282    11283    +1     
- Misses      18004    18005    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tarunps tarunps marked this pull request as ready for review December 27, 2024 08:57
@tarunps tarunps requested a review from 18alantom as a code owner December 27, 2024 08:57
@tarunps tarunps marked this pull request as draft December 27, 2024 09:26
@tarunps tarunps force-pushed the feat/custom-redis-mem-size branch 2 times, most recently from 6270a58 to bc4dbea Compare December 30, 2024 06:27
@tarunps tarunps changed the title feat: add field to allow configuring custom redis memory limit feat(press_settings): Add field to allow configuring custom redis memory limit Dec 30, 2024
@tarunps tarunps marked this pull request as ready for review December 30, 2024 06:42
@tarunps tarunps changed the title feat(press_settings): Add field to allow configuring custom redis memory limit feat(bench): Add field to allow configuring custom redis memory limit Dec 30, 2024
@tarunps tarunps force-pushed the feat/custom-redis-mem-size branch from bc4dbea to b3dc9ab Compare December 30, 2024 06:57
@tarunps tarunps force-pushed the feat/custom-redis-mem-size branch from b3dc9ab to a341ce9 Compare December 30, 2024 07:11
@adityahase adityahase merged commit 873be08 into frappe:master Jan 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow configuring redis memory limits on dedicated servers
2 participants