Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Revamped signup flow #2372

Open
wants to merge 65 commits into
base: master
Choose a base branch
from
Open

refactor: Revamped signup flow #2372

wants to merge 65 commits into from

Conversation

BreadGenie
Copy link
Member

@BreadGenie BreadGenie commented Dec 18, 2024

Sign up flow

Screen.Recording.2025-01-31.at.11.50.30.AM.mov

Log in flow

Screen.Recording.2025-01-31.at.4.58.49.PM.mov

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 5.17241% with 275 lines in your changes missing coverage. Please review.

Project coverage is 37.59%. Comparing base (efc1cec) to head (3e73685).
Report is 18 commits behind head on master.

Files with missing lines Patch % Lines
press/api/site_login.py 0.00% 71 Missing ⚠️
press/api/developer/saas.py 0.00% 41 Missing ⚠️
...ess/doctype/site_user_session/site_user_session.py 0.00% 35 Missing ⚠️
press/saas/doctype/product_trial/product_trial.py 10.81% 33 Missing ⚠️
press/press/doctype/site/site.py 13.79% 25 Missing ⚠️
press/api/marketplace.py 8.33% 22 Missing ⚠️
press/press/doctype/site_user/site_user.py 0.00% 21 Missing ⚠️
press/press/doctype/bench/bench.py 6.25% 15 Missing ⚠️
...ype/product_trial_request/product_trial_request.py 18.18% 9 Missing ⚠️
press/api/account.py 50.00% 1 Missing ⚠️
... and 2 more

❌ Your patch check has failed because the patch coverage (5.17%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2372      +/-   ##
==========================================
- Coverage   37.88%   37.59%   -0.29%     
==========================================
  Files         388      391       +3     
  Lines       30868    31146     +278     
==========================================
+ Hits        11694    11709      +15     
- Misses      19174    19437     +263     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BreadGenie BreadGenie changed the title refactor: revamped signup flow refactor: Revamped signup flow Jan 10, 2025
@rmehta
Copy link
Member

rmehta commented Jan 20, 2025

Any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants