Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #68
I've chosen to use
pyright
because it appears to be the current most advanced type checking tool available for Python. I've set this project to usestrict
type checking, but other settings arebasic
andstandard
. For most other Dissect projects, I think we should just start out withbasic
and incrementally increase it.The side-effect of type checking in the
lint
step are that we now must also install dependencies in order to check types with that.I've given it my best shot to make
dissect.util
adhere to thestrict
ruleset.