Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add symlink support to ZipFilesystem #808

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Add symlink support to ZipFilesystem #808

merged 2 commits into from
Aug 12, 2024

Conversation

Schamper
Copy link
Member

@Schamper Schamper commented Aug 7, 2024

This might fix #699 (@Zawadidone could you confirm?) and probably makes #793 redundant (sorry 😅).

This also reworks the internals of the ZipFilesystem a little bit.

@Schamper Schamper force-pushed the zip-symlink branch 2 times, most recently from 64ba5b2 to 8e569e8 Compare August 7, 2024 12:56
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 87.93103% with 7 lines in your changes missing coverage. Please review.

Project coverage is 75.56%. Comparing base (789009d) to head (e5cb3f5).

Files Patch % Lines
dissect/target/filesystems/zip.py 87.93% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #808      +/-   ##
==========================================
+ Coverage   75.53%   75.56%   +0.02%     
==========================================
  Files         299      299              
  Lines       25744    25782      +38     
==========================================
+ Hits        19445    19481      +36     
- Misses       6299     6301       +2     
Flag Coverage Δ
unittests 75.56% <87.93%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Zawadidone
Copy link
Contributor

Thanks it fixes #699!

@Horofic Horofic self-requested a review August 7, 2024 16:44
@Horofic Horofic self-assigned this Aug 7, 2024
dissect/target/filesystems/zip.py Outdated Show resolved Hide resolved
dissect/target/filesystems/zip.py Outdated Show resolved Hide resolved
@Schamper Schamper requested a review from Miauwkeru August 9, 2024 16:12
@Schamper Schamper force-pushed the zip-symlink branch 3 times, most recently from d12643a to 3743f53 Compare August 9, 2024 16:14
tests/filesystems/test_zip.py Outdated Show resolved Hide resolved
dissect/target/filesystems/zip.py Outdated Show resolved Hide resolved
dissect/target/filesystems/zip.py Outdated Show resolved Hide resolved
@Schamper Schamper merged commit 03d19e6 into main Aug 12, 2024
18 checks passed
@Schamper Schamper deleted the zip-symlink branch August 12, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZIP loader triggers an exception when loading Velociraptor Linux collections (Ubuntu)
4 participants