Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AttributeError to except ImportError statements #16

Closed
wants to merge 1 commit into from

Conversation

Miauwkeru
Copy link
Contributor

In some cases windows throws an AttributeError instead of an ImportError during an import

In some cases windows throws an AttributeError instead of a ImportError during import
@Miauwkeru Miauwkeru requested a review from pyrco February 1, 2024 15:27
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (eee455e) 86.32% compared to head (bd4115a) 86.32%.

Files Patch % Lines
dissect/squashfs/compression.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #16   +/-   ##
=======================================
  Coverage   86.32%   86.32%           
=======================================
  Files           5        5           
  Lines         373      373           
=======================================
  Hits          322      322           
  Misses         51       51           
Flag Coverage Δ
unittests 86.32% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper Schamper self-requested a review February 6, 2024 12:35
@Miauwkeru
Copy link
Contributor Author

went for a different solution

@Miauwkeru Miauwkeru closed this Feb 6, 2024
@Miauwkeru Miauwkeru deleted the dis-2726_make-robust-against-import-errors branch February 6, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants