Fix damage rolls not dealing atleast 1 damage #17414
Conversation
|
I'm not sure we want to set it to be at least 1 per instance. |
|
Any idea which direction this should be approached from then? check for it later or make it an option perhaps? |
|
It should probably just ensure that it's at least zero for each instance. Then the IWR application helper can pre-bump the damage to 1 if the summed non-persistent-damage instances start at zero. |
|
It seems that if IWR pre-bumps the damage to 1 it is only used when the actor has immunities/resistances to it. in the case of nothing and weaknesses the increase is ignored. |
|
It seems someone has been making something larger that could also fix this problem, but the code seems unfinished so this would be a smaller fix |
|
Hello! Could it be possible for someone to check this out? |
|
Sorry, the only person who can reasonably give you a good answer regarding IWR is stwlam, and I imagine he's very busy with V13 foundry dev at the current moment. |
|
Alright thanks for the answer. I'll leave this here and make another fork for the more complicated way of approaching this. |
closes #16484