Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test): add repro issue8566 testcase #9617

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

9547
Copy link
Contributor

@9547 9547 commented Jan 3, 2025

Motivation

Add a testcase for #8566

Solution

Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, you also have to add it to crates/forge/tests/it/repros.rs

@9547
Copy link
Contributor Author

9547 commented Jan 3, 2025

Thanks, you also have to add it to crates/forge/tests/it/repros.rs

thanks, may I ask is there any filter for nextest to run the specify repro issue?

@DaniPopes
Copy link
Member

After adding it to the rust file I believe you can simply pass the number to cargo test or cargo nextest

Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Note on a test failure

testdata/default/repros/Issue8566.t.sol Outdated Show resolved Hide resolved
@9547 9547 force-pushed the repro-issue8566 branch from 10a6e3d to 4a6d735 Compare January 3, 2025 12:41
@9547 9547 force-pushed the repro-issue8566 branch from 4a6d735 to 8186703 Compare January 3, 2025 12:45
@DaniPopes
Copy link
Member

DaniPopes commented Jan 4, 2025

Test failure fixed in alloy-primitives 0.8.17 alloy-rs/core#838

@zerosnacks zerosnacks self-requested a review January 6, 2025 09:42
@zerosnacks zerosnacks requested a review from DaniPopes January 6, 2025 09:48
@zerosnacks zerosnacks merged commit 782787b into foundry-rs:master Jan 6, 2025
22 checks passed
@9547 9547 deleted the repro-issue8566 branch January 6, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants