Support Django 2.0 #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@waseem-omar When we did upgrades for Memria and Donor, we dropped using django-users-plus library and maintained the code needed inside of those repos. Do we need to do this? |
nasief
suggested changes
May 29, 2019
waseem-omar
force-pushed
the
support_django_2.0
branch
from
fc9cd1f to
5846d0e
Compare
|
@waseem-omar For Memria, we refactored code related to masquerading, check this out |
nasief
reviewed
Jun 11, 2019
accountsplus/admin.py
Outdated
| @@ -185,7 +183,7 @@ def reset_passwords(self, request, queryset): | |||
| reset_passwords.short_description = 'Send password reset emails to selected Users' | |||
|
|
|||
| def get_timezone(self, obj): | |||
| return unicode(obj.timezone) | |||
| return str(obj.timezone) | |||
|
|
|||
| def masquerade(self, obj): | |||
| return '<a href="{}">sign in</a>'.format(django.urls.reverse('masquerade', kwargs={'user_id': obj.id})) | |||
There was a problem hiding this comment.
@waseem-omar I think we need to mark this as SafeString so that it appears as hyperlink in the table
There was a problem hiding this comment.
Should look like this django.utils.html.mark_safe('<a href="{}">sign in</a>'.format(django.urls.reverse('masquerade', kwargs={'user_id': obj.id})))
There was a problem hiding this comment.
Done @nasief, I have also refactored Masquerading views as you suggested above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.