feat: enable convertBitmapToLEDHex to trim or keep empty columns

[ZauberNerd]

This commit renames the previously unused isDrawn parameter to trim
and uses it to decide whether empty columns should be removed or not.

Summary by Sourcery

New Features:

• Added a trim parameter to convertBitmapToLEDHex to control whether empty columns are removed during conversion.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request renames the isDrawn parameter of the convertBitmapToLEDHex function to trim and uses it to determine whether or not to remove empty columns from the image before converting it to the LED hex format. The convertBitmapToLEDHex function now trims empty columns by default. The change also updates the call sites to pass true to the trim parameter.

Sequence diagram for bitmap to LED hex conversion with trimming

sequenceDiagram
    participant Client
    participant Converters

    Client->>Converters: convertBitmapToLEDHex(image, trim=true)
    Note over Converters: Process image from left to right
    Note over Converters: If trim=true, remove empty columns
    Note over Converters: Process image from right to left
    Note over Converters: If trim=true, remove empty columns
    Converters-->>Client: Return LED hex format strings

Loading

Class diagram showing Converters class changes

classDiagram
    class Converters {
        +convertBitmapToLEDHex(List~List~int~~ image, bool trim) List~String~
        note for Converters "Parameter renamed from isDrawn to trim"
        note for Converters "trim=true removes empty columns"
    }

Loading

State diagram for bitmap processing with trim option

stateDiagram-v2
    [*] --> CheckColumn
    CheckColumn --> SumPixels: For each column
    SumPixels --> CheckTrim: Sum = 0
    CheckTrim --> MarkForRemoval: trim = true
    CheckTrim --> KeepColumn: trim = false
    SumPixels --> KeepColumn: Sum > 0
    MarkForRemoval --> NextColumn
    KeepColumn --> NextColumn
    NextColumn --> CheckColumn: More columns
    NextColumn --> [*]: No more columns

Loading

File-Level Changes

Change	Details	Files
Renamed the isDrawn parameter to trim and updated its usage in the convertBitmapToLEDHex function.	Renamed the isDrawn parameter to trim. Added logic to remove empty columns based on the value of the trim parameter. Updated the logic for marking pixels in empty columns with -1 to be conditional on the trim parameter.	lib/bademagic_module/utils/converters.dart
Updated the call sites of the convertBitmapToLEDHex function to pass true for the trim parameter.	Changed the value passed to the convertBitmapToLEDHex function's second argument to true.	lib/bademagic_module/utils/image_utils.dart lib/view/draw_badge_screen.dart test/converters_test.dart

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @ZauberNerd - I've reviewed your changes - here's some feedback:

Overall Comments:

• Please add a test case that verifies the behavior when trim=false to ensure both code paths are covered

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}