Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fixed version of logger pre release, update dependencies, add test for validate expected error #26

Merged
merged 5 commits into from
Nov 16, 2023

Conversation

ani1311
Copy link
Collaborator

@ani1311 ani1311 commented Nov 16, 2023

$ go test -v -run ^TestLoggerNotWorking$ fortio.org/slack-proxy
=== RUN   TestLoggerNotWorking
{"ts":1700106049.775415,"level":"err","r":34,"file":"main_test.go","line":17,"msg":"Testing logging - err","err":"Channel is not set and Neither attachments, blocks, nor text is set"}
--- PASS: TestLoggerNotWorking (0.00s)
PASS
ok  	fortio.org/slack-proxy	0.154s

fixes ^ shows error now, was showing {}

fixed from fortio/log@df6a201

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5dc7d1c) 46.78% compared to head (a62e69c) 46.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #26   +/-   ##
=======================================
  Coverage   46.78%   46.78%           
=======================================
  Files           4        4           
  Lines         404      404           
=======================================
  Hits          189      189           
  Misses        206      206           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ldemailly ldemailly marked this pull request as ready for review November 16, 2023 03:39
Copy link
Member

@ldemailly ldemailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self "approving"

@ldemailly
Copy link
Member

ldemailly commented Nov 16, 2023

@ani1311 I let you look over this and if you're happy with it: merge and tag/release 0.5.0
(it'll also close the other dependabot PRs as I ran go get -u ./.... && go mod tidy)

@ldemailly ldemailly changed the title Test for log bug Use fixed version of logger pre release, update dependencies, add test for validate expected error Nov 16, 2023
@ani1311 ani1311 merged commit c968471 into main Nov 16, 2023
6 checks passed
@ani1311 ani1311 deleted the test-error-log branch November 16, 2023 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants