feat: Get LEVEL Creation to work #78
Conversation
|
@manish-singh-bisht is attempting to deploy a commit to the formbricks Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for following the naming conventions for pull request titles! 🙏 |
github-actions
bot
added
enhancement
manish-singh-bisht
changed the title
… i am wrong here)
|
Thanks a lot for shipping this and sorry for the delayed review. Most of the comments are related to the levels not being visible to the users. Pls recall that the levels are derived from the current points a user has. This should make it fairly easy to display both the current score and corresponding level / progress bar. Please make sure to build reusable components to which you can pass the levels object and the current point score. The component then decides what to display to each user. Does that make sense? Here the different views we need to see levels:
from 
to 
See here
If a repository has levels, we should display them in the leaderboard. 
If there is no user yet in a specific level, display a placeholder text: "No player levelled up here yet. Who's gonna be the first?"
We already pull all the labels from the issues. Find a good approach to compare the attached labels of issues with the label settings of all the levels a repository has. For each issue, display the badges of the levels which are eligible to work on this issue: 
While your own the issue component anyways, please update the styling to match the Figma layout.
Display the corresponding level emblem with the repo logo (in small) underneath the image: 
The above are the changes we need to make transparent who is on which level. Let's now get to the core functionality of levels: Giving specific players the right to work on some issues other dont. The key for this lays in these settings: 
For this first scope, we'll focus on this: 
How is this supposed to work?In this setting the maintainers can decide which level can work on issues with a specific label. For example this is level 1: Now a player wants to work on an issue because it is labeled as oss.gg. They try to /assign it and then our app checks if this player with their current level is allowed to work on the issue. It checks the labels and sees that the issue does not have the "beginner". Instead of assigning the user, it shows this message: "With your current level, you are not yet able to work on this issue." This allows maintainers to restrict issues to maintainers who are up for the challenge. |
|
@jobenjada ready for review. have added video in the description |
|
thanks a lot for following up, this looks really good :) Noticed one thing:
I'll go ahead and merge this regardless, as its a minor tweak which shouldn't block us :) |
|
/award 500 |
|
Awarding manish-singh-bisht: 500 points! |
This reverts commit 4df6031.
This reverts commit 4df6031.
* services,action,zod,level form,(not image) * corrected the replace button bug * correct the button variant, input is not changing * changed to arrow fxns * corrected the space * corrected the spacing * take 1- changed the update handlers in frontend only * image needs to be provided, removed the image fallback * changed the name environmentId to repositoryId, things may break(hope i am wrong here) * added delete from s3 functionality when delete level happens * feat:core functionality+visibility of levels * fix:now players with higher levels can take on task of lower levels * chore: shifted the sorting to the util function * fix:shows all tags from lower levels as well * fix:corrected the key * levels tweaks --------- Co-authored-by: Johannes <[email protected]>
* feat: Get LEVEL Creation to work (#78) * services,action,zod,level form,(not image) * corrected the replace button bug * correct the button variant, input is not changing * changed to arrow fxns * corrected the space * corrected the spacing * take 1- changed the update handlers in frontend only * image needs to be provided, removed the image fallback * changed the name environmentId to repositoryId, things may break(hope i am wrong here) * added delete from s3 functionality when delete level happens * feat:core functionality+visibility of levels * fix:now players with higher levels can take on task of lower levels * chore: shifted the sorting to the util function * fix:shows all tags from lower levels as well * fix:corrected the key * levels tweaks --------- Co-authored-by: Johannes <[email protected]> * solve build errors --------- Co-authored-by: Manish Singh Bisht <[email protected]>
What does this PR do?
fixes: #72
video1: showing visibility of levels
Screencast from 15-05-24 02:25:33 AM IST.webm
video2: showing functionality
Screencast from 15-05-24 02:16:23 AM IST.webm
How should this be tested?
Checklist
Required
pnpm buildconsole.logsgit pull origin mainAppreciated