Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 13.0 deprecations #3786

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Remove 13.0 deprecations #3786

merged 1 commit into from
Dec 20, 2024

Conversation

bbirman
Copy link
Member

@bbirman bbirman commented Dec 19, 2024

No description provided.

@@ -219,43 +220,6 @@ - (void)testRSAKeyGenerationDifferentKey

}

- (void)testRSAEncryptionAndDecryption
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new equivalent tests are in CryptoUtilsTests.swift

Copy link

1 Warning
⚠️ Static Analysis found an issue with one or more files you modified. Please fix the issue(s).

Clang Static Analysis Issues

File Type Category Description Line Col
SFSDKCryptoUtils Leak Memory (Core Foundation/Objective-C/OSObject) Potential leak of an object stored into 'privateAccess' 233 48
SFSDKCryptoUtils Leak Memory (Core Foundation/Objective-C/OSObject) Potential leak of an object stored into 'privateKey' 261 29

Generated by 🚫 Danger

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.55%. Comparing base (994f52f) to head (c66d0e3).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3786      +/-   ##
==========================================
- Coverage   62.91%   62.55%   -0.36%     
==========================================
  Files         223      223              
  Lines       21332    21457     +125     
==========================================
+ Hits        13420    13423       +3     
- Misses       7912     8034     +122     
Components Coverage Δ
Analytics 84.09% <ø> (ø)
Common 68.96% <ø> (ø)
Core 51.35% <ø> (-0.48%) ⬇️
SmartStore 73.70% <ø> (ø)
MobileSync 87.58% <ø> (ø)
Files with missing lines Coverage Δ
...esforceSDKCore/Classes/Security/SFSDKCryptoUtils.m 60.80% <ø> (-18.10%) ⬇️
...lesforceSDKCore/Classes/Util/SFApplicationHelper.m 13.79% <ø> (-0.50%) ⬇️
...KCore/SalesforceSDKCore/Classes/Util/SFSDKOAuth2.m 40.93% <ø> (-1.75%) ⬇️

... and 2 files with indirect coverage changes

@bbirman bbirman merged commit 4ee1195 into forcedotcom:dev Dec 20, 2024
11 of 14 checks passed
@bbirman bbirman deleted the 13-cleanup branch December 20, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants