API-2: basic endpoints #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paroga
approved these changes
Oct 13, 2018
| @@ -0,0 +1,9 @@ | |||
| class Api::V1::UsersController < Api::V1::BaseController | |||
|
|
|||
| before_action :authenticate | |||
There was a problem hiding this comment.
can we make it the default in BaseController and just skip it where we don't need it?
app/serializers/config_serializer.rb
Outdated
| @@ -0,0 +1,30 @@ | |||
| class ConfigSerializer < ActiveModel::Serializer | |||
| attributes :name, :homepage, :contact, | |||
There was a problem hiding this comment.
They're now somewhat grouped by similarity, so that when you first inspect the API output, it is easier to read. I'll make this more explicit.
wvengen
force-pushed
the
feature/api-2-endpoints-basic
branch
from
59dc732 to
9a2cbdf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part two of #429 in chunks, continued from #570: basic endpoints
/api/v1/user/api/v1/config/api/v1/navigation