Skip to content

Commit

Permalink
Disable JavaScript errors in tests
Browse files Browse the repository at this point in the history
  • Loading branch information
paroga committed Sep 5, 2020
1 parent 899a83b commit c6250de
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions spec/spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@
Capybara.server = :puma, { Silent: true }
Capybara.javascript_driver = :apparition

#TODO: Remove temporary fix to ignore JavaScript errors
Capybara.register_driver :apparition do |app|
Capybara::Apparition::Driver.new(app, {js_errors: false})
end

This comment has been minimized.

Copy link
@wvengen

wvengen Sep 5, 2020

Member

Hmmm, strange. Why do Java-script-dependent tests succeed even with there is broken Javascript?
Something to figure out, at least I'm happy CI is green again. 💯

This comment has been minimized.

Copy link
@paroga

paroga Sep 5, 2020

Author Member

do we really have any JS test? AFAIK we do not depend on any client side JavaScript

# Requires supporting ruby files with custom matchers and macros, etc,
# in spec/support/ and its subdirectories.
Dir[Rails.root.join("spec/support/**/*.rb")].each { |f| require f }
Expand Down

0 comments on commit c6250de

Please sign in to comment.