Improve financial link feature & transaction links #658
twothreenineAnnotations
8 errors and 2 warnings
|
test:
app/controllers/finance/financial_links_controller.rb#L16
Style/ConditionalAssignment: Use the return of the conditional for variable assignment and comparison.
|
|
test:
app/models/order.rb#L1
Metrics/ClassLength: Class has too many lines. [304/294]
|
|
test:
app/models/order.rb#L274
Style/OptionalBooleanParameter: Prefer keyword arguments for arguments with a boolean default value; use `create_foodcoop_transaction: false` instead of `create_foodcoop_transaction = false`.
|
|
test:
db/migrate/20240404004950_add_use_financial_links_setting.rb#L2
Style/CommentedKeyword: Do not place comments on the same line as the `def` keyword.
|
|
test:
db/migrate/20240404004950_add_use_financial_links_setting.rb#L3
Style/GuardClause: Use a guard clause (`return unless FinancialLink.any? or FinancialTransaction.where(ordergroup: nil).any?`) instead of wrapping the code inside a conditional expression.
|
|
test:
db/migrate/20240404004950_add_use_financial_links_setting.rb#L3
Style/IfUnlessModifier: Favor modifier `if` usage when having a single-line body. Another good alternative is the usage of control flow `&&`/`||`.
|
|
test:
db/migrate/20240404004950_add_use_financial_links_setting.rb#L3
Style/AndOr: Use `||` instead of `or`.
|
|
test
Process completed with exit code 1.
|
|
test
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|