mock HTTP requests in the test suite #4621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With these changes, the only remaining test case in the regression test suite which makes a network request is If you like this approach of using requests-mock, I could refactor the That would allow the complete test suite to run without making any network requests. |
felipesanches
force-pushed
the
mock-http
branch
from
71636b5 to
5354804
Compare
This seems to be equivalent, and it makes it easier to mock the necessary HTTP requests in the test cases for the vertical_metrics and cjk_vertical_metrics conditions. We only need to mock the metadata lookup, rather than a complete zip file that is never used.
This makes it easier to mock out the request to Github in the tests.
This lets the test suite work in environments where network access is restricted. It also lets us easily test for HTTP errors like timeouts.
|
Hey, @danc86, it took me a long time to do it, but here it is: reviewed and merged! ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm working on packaging fontbakery in nixpkgs, which requires that the test suite run without network access. I found a few tests which intentionally make network calls, but in most of them it seems desirable to mock out requests to live services. This will make them faster and more reproducible, and lets them run in an environment like nixpkgs where they are sandboxed from the network.
Checklist
CHANGELOG.md