Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report each code once in succinct mode #4617

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

simoncozens
Copy link
Collaborator

Description

Rather than

BriemHand[wght].ttf: com.google.fonts/check/tabular_kerning: FAIL [has-tabular-kerning, has-tabular-kerning, has-tabular-kerning,
has-tabular-kerning, has-tabular-kerning, has-tabular-kerning,
has-tabular-kerning, has-tabular-kerning, has-tabular-kerning,
has-tabular-kerning, has-tabular-kerning, has-tabular-kerning,
has-tabular-kerning, has-tabular-kerning, has-tabular-kerning,
has-tabular-kerning, has-tabular-kerning, has-tabular-kerning,
...

it makes more sense to say:

BriemHand[wght].ttf: com.google.fonts/check/tabular_kerning: FAIL [has-tabular-kerning]

Checklist

  • update CHANGELOG.md
  • wait for the tests to pass
  • request a review

@felipesanches
Copy link
Collaborator

Ouch! I agree.

You saw that on a google/fonts PR?

@felipesanches felipesanches added this to the 0.12.0 milestone Mar 27, 2024
@felipesanches felipesanches merged commit 26047be into main Mar 27, 2024
112 checks passed
@khaledhosny khaledhosny deleted the succinct-report-once branch April 17, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants