Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better max_length check #4367

Merged
merged 4 commits into from
Dec 11, 2023
Merged

Better max_length check #4367

merged 4 commits into from
Dec 11, 2023

Conversation

simoncozens
Copy link
Collaborator

@simoncozens simoncozens commented Dec 11, 2023 •
edited
Loading

Description

Relates to issue #2179, #4104.

This check now implements the following three rules:

  • nameID4 (without RIBBI) > 31: WARN: problems with dropdown menu in old versions of Word
  • nameID 6 > 27: WARN : problems with mac and postscript printers
  • name ID 1 + fvar instance name > 31 : WARN : problems with Windows

Checklist

  • update CHANGELOG.md
  • wait for the tests to pass
  • request a review

@simoncozens
Copy link
Collaborator Author 

F0010 (parse-error) tests/__init__.py @ 1 — error while code parsing: Unable to load file tests/__init__.py:

This one's not my fail...

@felipesanches felipesanches merged commit 52514c4 into main Dec 11, 2023
40 checks passed
@khaledhosny khaledhosny deleted the better-max_length branch January 10, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipesanches felipesanches Awaiting requested review from felipesanches

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simoncozens @felipesanches