Deprecate family/equal_unicode_encodings check

com.google.fonts/check/family/equal_unicode_encodings Removed from the OpenType profile. (issue #4569)
fonttools · Mar 6, 2024 · ebc4f78 · ebc4f78
1 parent 6477572
commit ebc4f78
Show file tree

Hide file tree

Showing 7 changed files with 2 additions and 103 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -14,6 +14,7 @@ A more detailed list of changes is available in the corresponding milestones for
 ### Deprecated checks
 #### Removed from the Open Type profile
   - **[com.google.fonts/check/family/panose_proportion]:** (issue #4083)
+  - **[com.google.fonts/check/family/equal_unicode_encodings]:** (issue #4569)
 
 ### Changes to existing checks
 #### On the Google Fonts profile
@@ -76,7 +77,6 @@ A more detailed list of changes is available in the corresponding milestones for
 
 #### On the Open Type Profile
   - **[com.google.fonts/check/family/equal_font_versions]:** Added rationale. (PR #4570)
-  - **[com.google.fonts/check/family/equal_unicode_encodings]:** Added rationale, even though this is a questionable check, which we may simply deprecate, as we're not sure why would we expect what it checks. (PR #4570)
   - **[com.google.fonts/check/family_naming_recommendations]:** Added rationale. (PR #4570)
   - **[com.google.fonts/check/family/panose_familytype]:** Add rationale and improve message when there are inconsistencies. (PR #4570)
   - **[com.google.fonts/check/font_version]:** Added rationale. (PR #4570)

diff --git a/Lib/fontbakery/checks/opentype/cmap.py b/Lib/fontbakery/checks/opentype/cmap.py
diff --git a/Lib/fontbakery/profiles/adobefonts.py b/Lib/fontbakery/profiles/adobefonts.py
@@ -16,9 +16,6 @@
             "com.adobe.fonts/check/cff_call_depth",
             "com.adobe.fonts/check/cff_deprecated_operators",
         ],
-        "cmap": [
-            "com.google.fonts/check/family/equal_unicode_encodings",
-        ],
         "fontwerk": [
             "com.fontwerk/check/inconsistencies_between_fvar_stat",  # IS_OVERRIDDEN
             "com.fontwerk/check/weight_class_fvar",  # IS_OVERRIDDEN

diff --git a/Lib/fontbakery/profiles/opentype.py b/Lib/fontbakery/profiles/opentype.py
@@ -3,7 +3,6 @@
         "OpenType Specification Checks": [
             "com.google.fonts/check/family/underline_thickness",
             "com.google.fonts/check/family/panose_familytype",
-            "com.google.fonts/check/family/equal_unicode_encodings",
             "com.google.fonts/check/family/equal_font_versions",
             "com.adobe.fonts/check/family/bold_italic_unique_for_nameid1",
             "com.adobe.fonts/check/family/max_4_fonts_per_family_name",

diff --git a/Lib/fontbakery/profiles/typenetwork.py b/Lib/fontbakery/profiles/typenetwork.py
@@ -31,9 +31,6 @@
             "com.adobe.fonts/check/cff2_call_depth",
             "com.adobe.fonts/check/cff_deprecated_operators",
         ],
-        "cmap table": [
-            "com.google.fonts/check/family/equal_unicode_encodings",
-        ],
         "DSIG": [
             "com.google.fonts/check/dsig",
         ],

diff --git a/docs/source/fontbakery/checks/opentype.rst b/docs/source/fontbakery/checks/opentype.rst
@@ -14,12 +14,6 @@ CFF table checks
 .. automodule:: fontbakery.checks.opentype.cff
     :members:
 
-cmap table checks
-*****************
-
-.. automodule:: fontbakery.checks.opentype.cmap
-    :members:
-
 DSIG table checks
 *****************
 
@@ -102,4 +96,4 @@ STAT table checks
 *****************
 
 .. automodule:: fontbakery.checks.opentype.stat
-    :members:
+    :members:
diff --git a/tests/checks/opentype/cmap_test.py b/tests/checks/opentype/cmap_test.py