Skip to content

Commit

Permalink
Add rationale for equal_codepoint_coverage check
Browse files Browse the repository at this point in the history
com.google.fonts/check/family/equal_codepoint_coverage
On the Google Fonts Profile.

(PR #4570)
  • Loading branch information
simoncozens authored and felipesanches committed Mar 5, 2024
1 parent b5cce08 commit e2999fd
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ A more detailed list of changes is available in the corresponding milestones for
- **[com.google.fonts/check/metadata/familyname]:** Added rationale and improve display of detected inconsistencies. (PR #4570)
- **[com.google.fonts/check/name/version_format]:** Added rationale. (PR #4570)
- **[com.google.fonts/check/name/mandatory_entries]:** Added rationale. (PR #4570)
- **[com.google.fonts/check/family/equal_codepoint_coverage]:** Added rationale. (PR #4570)

#### On the FontValidator profile
- **[com.google.fonts/check/fontvalidator]:** Added rationale. (PR #4570)
Expand Down
7 changes: 7 additions & 0 deletions Lib/fontbakery/checks/googlefonts/family.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,13 @@
id="com.google.fonts/check/family/equal_codepoint_coverage",
conditions=["are_ttf", "stylenames_are_canonical"],
proposal="https://github.com/fonttools/fontbakery/issues/4180",
rationale="""
For a given family, all fonts must have the same codepoint coverage.
This is because we want to avoid the situation where, for example,
a character is present in a regular font but missing in the italic style;
turning on italic would cause the character to be rendered either as a
fake italic (auto-slanted) or to show tofu.
""",
)
def com_google_fonts_check_family_equal_codepoint_coverage(fonts, config):
"""Fonts have equal codepoint coverage"""
Expand Down

0 comments on commit e2999fd

Please sign in to comment.