Skip to content

Commit

Permalink
Add rationale to ttx_roundtrip check
Browse files Browse the repository at this point in the history
com.google.fonts/check/ttx_roundtrip
On the Universal profile.

(PR #4570)
  • Loading branch information
simoncozens authored and felipesanches committed Mar 5, 2024
1 parent 2f68790 commit ca49f67
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ A more detailed list of changes is available in the corresponding milestones for

#### On the Universal profile
- **DISABLED - [com.google.fonts/check/legacy_accents]:** This is one of the checks that we probably should run on the sources instead of binaries. (https://github.com/fonttools/fontbakery/issues/3959#issuecomment-1822913547)
- **[com.google.fonts/check/ttx_roundtrip]:** Added rationale. (PR #4570)

#### On the Open Type Profile
- **[com.google.fonts/check/layout_valid_feature_tags]:** Updated the check to allow valid private-use feature tags. (issue #4544)
Expand Down
7 changes: 7 additions & 0 deletions Lib/fontbakery/checks/universal/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -1296,6 +1296,13 @@ def com_google_fonts_check_unique_glyphnames(ttFont):
@check(
id="com.google.fonts/check/ttx_roundtrip",
conditions=["not vtt_talk_sources"],
rationale="""
One way of testing whether or not fonts are well-formed at the
binary level is to convert them to TTX and then back to binary. Structural
problems within the binary font will show up as errors during conversion.
This is not necessarily something that a designer will be able to address
but is evidence of a potential bug in the font compiler used to generate
the binary.""",
proposal="https://github.com/fonttools/fontbakery/issues/1763",
)
def com_google_fonts_check_ttx_roundtrip(font):
Expand Down

0 comments on commit ca49f67

Please sign in to comment.