Add rationale for version_bump

com.google.fonts/check/version_bump On the Google Fonts Profile. (PR #4570)
fonttools · Mar 5, 2024 · 8a60eee · 8a60eee
1 parent 4e5463c
commit 8a60eee
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -50,6 +50,7 @@ A more detailed list of changes is available in the corresponding milestones for
   - **[com.google.fonts/check/has_ttfautohint_params]:** Added rationale. (PR #4570)
   - **[com.google.fonts/check/smart_dropout]:** Improve rationale with better fixing instructions. (PR #4570)
   - **[com.google.fonts/check/production_glyphs_similarity]:** Added rationale. (PR #4570)
+  - **[com.google.fonts/check/version_bump]:** Added rationale. (PR #4570)
 
 #### On the FontValidator profile
   - **[com.google.fonts/check/fontvalidator]:** Added rationale. (PR #4570)

diff --git a/Lib/fontbakery/checks/googlefonts/hosted.py b/Lib/fontbakery/checks/googlefonts/hosted.py
@@ -5,6 +5,11 @@
     id="com.google.fonts/check/version_bump",
     conditions=["api_gfonts_ttFont", "github_gfonts_ttFont"],
     proposal="legacy:check/117",
+    rationale="""
+        We check that the version number has been bumped since the last release on
+        Google Fonts. This helps to ensure that the version being PRed is newer than
+        the one currently hosted on fonts.google.com.
+    """,
 )
 def com_google_fonts_check_version_bump(
     ttFont, api_gfonts_ttFont, github_gfonts_ttFont