Skip to content

Commit

Permalink
Add rationale for check/name/unwanted_chars
Browse files Browse the repository at this point in the history
com.google.fonts/check/name/unwanted_chars
On the Google Fonts Profile.

(PR #4570)
  • Loading branch information
simoncozens authored and felipesanches committed Mar 5, 2024
1 parent ac87f85 commit 791d23f
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ A more detailed list of changes is available in the corresponding milestones for
- **[com.google.fonts/check/version_bump]:** Added rationale. (PR #4570)
- **[com.google.fonts/check/family/has_license]:** Added rationale. (PR #4570)
- **[com.google.fonts/check/metadata/license]:** Added rationale. (PR #4570)
- **[com.google.fonts/check/name/unwanted_chars]:** Added rationale. (PR #4570)

#### On the FontValidator profile
- **[com.google.fonts/check/fontvalidator]:** Added rationale. (PR #4570)
Expand Down
10 changes: 9 additions & 1 deletion Lib/fontbakery/checks/googlefonts/name.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,15 @@
from fontbakery.utils import markdown_table


@check(id="com.google.fonts/check/name/unwanted_chars", proposal="legacy:check/019")
@check(
id="com.google.fonts/check/name/unwanted_chars",
proposal="legacy:check/019",
rationale="""
We don't want non-ASCII characters in name table entries; in particular,
copyright, trademark and registered symbols should be written using
their ASCII counterparts: e.g. (c), (tm) and (r) respectively.
""",
)
def com_google_fonts_check_name_unwanted_chars(ttFont):
"""Substitute copyright, registered and trademark
symbols in name table entries."""
Expand Down

0 comments on commit 791d23f

Please sign in to comment.