MODSOURCE-729 - Implement new endpoint to be used for matching #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RuslanLavrov
requested review from
VRohach,
Aliaksandr-Fedasiuk,
okolawole-ebsco,
KaterynaSenchenko,
RomanChernetskyi,
yaroslav-epam,
JavokhirAbdullayev and
Maksat-Galymzhan
KaterynaSenchenko
approved these changes
Feb 2, 2024
mod-source-record-storage-server/src/main/java/org/folio/dao/RecordDaoImpl.java
Show resolved
Hide resolved
mod-source-record-storage-server/src/main/java/org/folio/dao/RecordDaoImpl.java
Show resolved
Hide resolved
mod-source-record-storage-server/src/main/java/org/folio/services/RecordServiceImpl.java
Show resolved
Hide resolved
mod-source-record-storage-server/src/test/java/org/folio/rest/impl/RecordsMatchingApiTest.java
Outdated
Show resolved
Hide resolved
|
Nice to see good javadocs on your methods! |
VRohach
approved these changes
Feb 5, 2024
mod-source-record-storage-server/src/main/java/org/folio/services/RecordServiceImpl.java
Outdated
Show resolved
Hide resolved
RuslanLavrov
force-pushed
the
MODSOURCE-729
branch
from
fc58fd9 to
fe4b56a
Compare
RuslanLavrov
force-pushed
the
MODSOURCE-729
branch
from
8b806cf to
0356e73
Compare
…hing by matchedId, externalId, externalHrid
RuslanLavrov
force-pushed
the
MODSOURCE-729
branch
from
bc78aca to
4f48dec
Compare
…ge into MODSOURCE-729
…rom escaped format
…ge into MODSOURCE-729
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
to implement new endpoint to be used for MARC records matching
Approach
POST /source-storage/records/matchingendpoint that consumes matching conditions from request body and provides pagination capabilities. The endpoint returns RecordsIdentifiersCollection containing list of pairs (recordId, externalId) in a response.Learning
MODSOURCE-729
Requires: PR folio-org/data-import-raml-storage#306