Parse SVD format register definition files #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RegisterView.py
Outdated
| r.set('fullname', fullname) | ||
| # Calculate absolute address | ||
| offset = r.find('addressOffset').text | ||
| r.set('address', hex(int(new_base_address,16) + int(offset,16))) |
There was a problem hiding this comment.
base = 16 before this? to avoid the magic number feel :)
| peripheral.insert(0, new_elements) | ||
|
|
||
| # No need to do anything else - complete copy has been made | ||
| return |
There was a problem hiding this comment.
yes, because all the stuff that happens below is irrelevant when the peripheral is derived from another one and a deep copy of it has been made :)
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added SVD file parsing via new command "regview loadsvd".
Format is adapted during load so it can use the same view function as the eclipse xml load.
Makes this tool really useful for me, because many more MCU register definitions are available in this format. I've included STM32429 as a sample (the one I'm targeting).