Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report error on duplicate named arg names #4367

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Report error on duplicate named arg names #4367

wants to merge 3 commits into from
+22 −0

Conversation

dinomight
Copy link
Contributor

Compile error will happen if static named args are used and enabled. Runtime exception will be thrown in other cases.
#4282

@dinomight
Copy link
Contributor Author

Wanted to mention that this does not handle the case of using FMT_COMPILE strings. That infrastructure is a bit different and doesn't utilize either of the functions I've updated here. It should be doable for FMT_COMPILE string, but might require additional memory to do the duplicate name check. I'm not sure what the preferred technique is there. Should I file a separate ticket to track?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dinomight