Skip to content

Commit

Permalink
Updated README, removed unused env vars
Browse files Browse the repository at this point in the history
Signed-off-by: Jason Porter <[email protected]>
  • Loading branch information
jsonporter committed Feb 23, 2024
1 parent a510215 commit d60733b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 7 deletions.
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ We've recently updated FlyteConsole with a number of changes, including a refres

Most of these changes are non-breaking however, there are a few things we've changed:

- removed FLYTE_NAVIGATION
- removed registry
- removed Google Analytics
- `FLYTE_NAVIGATION` and `HORIZONTAL_LAYOUT` env vars have been removed. These were used to provide configuration options to the page layout and navigation but are no longer needed as the new navigation is fixed.
- `ENABLE_GA` and `GA_TRACKING_ID` env vars have been removed. These were used to configure Google Analytics; Google Analytics was removed.
- `ExternalConfigurationProviderProps` and `registry` have been removed. These were used to provide override capabilities to specific components and were removed for simplicity.

## 📦 Install Dependencies

Expand Down
1 change: 0 additions & 1 deletion packages/common/src/environment/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ export interface Env extends NodeJS.ProcessEnv {
*/
BASE_HREF?: string;
DISABLE_CONSOLE_ROUTE_PREFIX?: string;
FLYTE_NAVIGATION?: string;

DISABLE_ANALYTICS?: string;
NODE_ENV?: 'development' | 'production' | 'test';
Expand Down
3 changes: 0 additions & 3 deletions website/console/env/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,6 @@ const DISABLE_CONSOLE_ROUTE_PREFIX = process.env.DISABLE_CONSOLE_ROUTE_PREFIX ||
*/
const ASSETS_PATH = `${BASE_URL}/assets/`;

const FLYTE_NAVIGATION = process.env.FLYTE_NAVIGATION || '';

/**
* This is used to prevent use of the app during outages.
* If this is set to 'true', the app will display a maintenance page.
Expand All @@ -83,7 +81,6 @@ const processEnv = {
BASE_URL,
BASE_HREF,
DISABLE_CONSOLE_ROUTE_PREFIX,
FLYTE_NAVIGATION,
MAINTENANCE_MODE,
};

Expand Down

0 comments on commit d60733b

Please sign in to comment.