Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typos in documentation files #6233

Merged
merged 3 commits into from
Feb 12, 2025
Merged

Conversation

maximevtush
Copy link
Contributor

@maximevtush maximevtush commented Feb 8, 2025

Summary by Bito

Fixed a consistent typo in variable naming across multiple test files, changing 'dereferencableKindsConfig' to 'dereferenceableKindsConfig'. This change enhances code readability and maintains consistent spelling conventions throughout the project's test suite.

Unit tests added: False

Estimated effort to review (1-5, lower is better): 1

Copy link

welcome bot commented Feb 8, 2025

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@flyte-bot
Copy link
Collaborator

flyte-bot commented Feb 8, 2025

Code Review Agent Run #997e5c

Actionable Suggestions - 0
Review Details
  • Files reviewed - 3 · Commit Range: e4ffa0b..9f7410c
    • flyteplugins/go/tasks/plugins/array/k8s/config_flags_test.go
    • flyteplugins/go/tasks/plugins/presto/config/config_flags_test.go
    • flytestdlib/logger/config_flags_test.go
  • Files skipped - 0
  • Tools
    • Golangci-lint (Linter) - ✖︎ Failed
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

AI Code Review powered by Bito Logo

@flyte-bot
Copy link
Collaborator

Changelist by Bito

This pull request implements the following key changes.

Key Change Files Impacted
Documentation - Fix Variable Name Typo in Test Files

config_flags_test.go - Fixed typo in variable name from 'dereferencableKindsConfig' to 'dereferenceableKindsConfig'

config_flags_test.go - Fixed typo in variable name from 'dereferencableKindsConfig' to 'dereferenceableKindsConfig'

config_flags_test.go - Fixed typo in variable name from 'dereferencableKindsConfig' to 'dereferenceableKindsConfig'

@davidmirror-ops davidmirror-ops self-requested a review February 12, 2025 15:14
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.87%. Comparing base (34205dd) to head (9f7410c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6233   +/-   ##
=======================================
  Coverage   36.87%   36.87%           
=======================================
  Files        1318     1318           
  Lines      134647   134647           
=======================================
  Hits        49647    49647           
  Misses      80679    80679           
  Partials     4321     4321           
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 51.96% <ø> (ø)
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl 62.29% <ø> (ø)
unittests-flyteidl 7.22% <ø> (ø)
unittests-flyteplugins 54.02% <ø> (ø)
unittests-flytepropeller 42.78% <ø> (ø)
unittests-flytestdlib 55.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@davidmirror-ops davidmirror-ops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@davidmirror-ops davidmirror-ops merged commit 592f1c4 into flyteorg:master Feb 12, 2025
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants