Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add on failure node passing err message doc #6209

Conversation

popojk
Copy link
Contributor

@popojk popojk commented Feb 3, 2025

Tracking issue

Related to #6181

Why are the changes needed?

In this PR, the error message will be passed to the on_failure node if an error occurs during workflow execution. We have added the relevant documentation in this PR.

What changes were proposed in this pull request?

Added a note explaining how to pass the error message to the on_failure node.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All commits are signed-off.

Related PRs

PR

Docs link

https://flyte--6209.org.readthedocs.build/en/6209/user_guide/development_lifecycle/failure_node.html

Signed-off-by: Alex Wu <[email protected]>
@popojk popojk requested a review from ppiegaze as a code owner February 3, 2025 06:42
@flyte-bot
Copy link
Collaborator

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.90%. Comparing base (ab463c3) to head (6c6382b).
Report is 29 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6209      +/-   ##
==========================================
- Coverage   37.06%   36.90%   -0.17%     
==========================================
  Files        1318     1317       -1     
  Lines      132644   134061    +1417     
==========================================
+ Hits        49164    49474     +310     
- Misses      79230    80294    +1064     
- Partials     4250     4293      +43     
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 52.48% <ø> (-1.86%) ⬇️
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl 62.29% <ø> (ø)
unittests-flyteidl 7.23% <ø> (ø)
unittests-flyteplugins 53.87% <ø> (+0.02%) ⬆️
unittests-flytepropeller 42.73% <ø> (+0.02%) ⬆️
unittests-flytestdlib 55.33% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@davidmirror-ops davidmirror-ops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @popojk!

@davidmirror-ops davidmirror-ops merged commit d3a34ed into flyteorg:master Feb 12, 2025
52 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants