Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log streaming response #4776

Closed
wants to merge 5 commits into from
Closed

Log streaming response #4776

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8431f47
Streaming log for agent
pingsutw Jan 23, 2024
ddd25cd
nit
pingsutw Jan 23, 2024
d95e733
update tests
pingsutw Jan 23, 2024
bf2fe55
remove token
pingsutw Jan 24, 2024
29fc426
Streaming response
EngHabu Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions flyteidl/protos/flyteidl/admin/agent.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,18 @@ message GetTaskLogsRequest {
bytes resource_meta = 2;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want token and limit here as well, right?


message GetTaskLogsResponseHeader {
string token = 1;
}

message GetTaskLogsResponseBody {
repeated string results = 1;
}

// A response containing the logs for a task execution.
message GetTaskLogsResponse {
// The execution log results.
string results = 1;
oneof part {
GetTaskLogsResponseHeader header = 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the response pattern end up looking like

GetTaskLogsResponse{Header{token=3}}
GetTaskLogsResponse{Body{results=[...]}} // 3 log lines
GetTaskLogsResponse{Header{token=9}
GetTaskLogsResponse{Body{results=[...]}} // 6 log lines

And then a future request call would include token=9?

GetTaskLogsResponseBody body = 2;
}
}
Loading