Log streaming response #4776
Closed
Log streaming response #4776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Haytham Abuelfutuh <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4776 +/- ##
==========================================
- Coverage 58.21% 58.19% -0.02%
==========================================
Files 626 626
Lines 53855 53950 +95
==========================================
+ Hits 31349 31394 +45
- Misses 19996 20045 +49
- Partials 2510 2511 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andrewwdye
reviewed
Jan 25, 2024
| // The execution log results. | ||
| string results = 1; | ||
| oneof part { | ||
| GetTaskLogsResponseHeader header = 1; |
There was a problem hiding this comment.
Does the response pattern end up looking like
GetTaskLogsResponse{Header{token=3}}
GetTaskLogsResponse{Body{results=[...]}} // 3 log lines
GetTaskLogsResponse{Header{token=9}
GetTaskLogsResponse{Body{results=[...]}} // 6 log lines
And then a future request call would include token=9?
| @@ -160,8 +160,18 @@ message GetTaskLogsRequest { | |||
| bytes resource_meta = 2; | |||
| } | |||
There was a problem hiding this comment.
We want token and limit here as well, right?
|
Cleaning stale PRs. Please reopen if you wan to discuss this further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
https://github.com/flyteorg/flyte/issues/
Why are the changes needed?
What changes were proposed in this pull request?
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link