support setting of imagePullSecrets for all controllers #53 #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity#53 Example helm cli usage to provide an imagePullSecret ``` helm ... --set "imagePullSecrets[0].name=secret1" ``` Signed-off-by: Robert R Allen <[email protected]>
|
reopen after rebase |
|
@haarchri It looks like you need to approve again since I cleared content of MR to rebase |
|
LGTM. Thanks for the effort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example helm cli usage to provide an imagePullSecret
Signed-off-by: Robert R Allen [email protected]
What this PR does / why we need it:
The flux CLI supports customizing the imagePullSecrets. This brings equivalent behavior to the helm chart.
Which issue this PR fixes
flux -install#53Special notes for your reviewer:
Checklist