Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport(v1.16) test_cat: use proper protocol in unused_port method (#4686) #4793

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

kenhys
Copy link
Contributor

@kenhys kenhys commented Jan 29, 2025

Which issue(s) this PR fixes:

Backport #4686

What this PR does / why we need it:

Fixes an issue where an inappropriate protocol was specified in the unused_port method.
See #4674 (comment)

Docs Changes:

Release Note:

Signed-off-by: Watson <[email protected]>
Co-authored-by: Daijiro Fukuda <[email protected]>
Signed-off-by: Kentaro Hayashi <[email protected]>
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@daipom daipom merged commit 0ae4094 into v1.16 Jan 29, 2025
12 of 16 checks passed
@daipom daipom deleted the backport-pr4686 branch January 29, 2025 02:25
@daipom daipom changed the title test_cat: use proper protocol in unused_port method (#4686) Backport(v1.16) test_cat: use proper protocol in unused_port method (#4686) Jan 29, 2025
@daipom daipom added this to the v1.16.7 milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants