Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport(v1.16) tests: fix unused_port (PR#4675) #4788

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

kenhys
Copy link
Contributor

@kenhys kenhys commented Jan 28, 2025

Which issue(s) this PR fixes:

Fixes #4674

What this PR does / why we need it:

It obtains unused port number for TCP by unused_port method and the number has been used in UDP.
And that number may be already used by UDP sockets.

This patch will obtain and use unused ports appropriately for each protocol.

Backported from #4675

Docs Changes:

Release Note:

It obtains unused port number for TCP by unused_port method and the number has been used in UDP.
And that number may be already used by UDP sockets.
This patch will obtain and use unused ports appropriately for each protocol.

See #4675

Signed-off-by: Watson <[email protected]>
Signed-off-by: Kentaro Hayashi <[email protected]>
@kenhys kenhys added this to the v1.16.7 milestone Jan 28, 2025
@kenhys
Copy link
Contributor Author

kenhys commented Jan 28, 2025

Backport with:

git switch -c backport-pr4675 --track origin/v1.16
git cherry-pick 0634bd5e4488c2a11895beaf60e341074914ff82

@kenhys kenhys requested a review from daipom January 28, 2025 09:04
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@daipom daipom merged commit 0c5b764 into v1.16 Jan 29, 2025
8 of 16 checks passed
@daipom daipom deleted the backport-pr4675 branch January 29, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants