Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate mpeg2 video support into fluster #250

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Conversation

rsanchez87
Copy link
Contributor

No description provided.

@rsanchez87 rsanchez87 marked this pull request as draft February 6, 2025 10:35
@ylatuya
Copy link
Contributor

ylatuya commented Feb 6, 2025

This PR is adding new test suites to fluster, hence new features but none of your commits has a feature: type.

You should split build: compilation: add gen_mpeg2_video.py in the absence of raw file creation into 2 commits, one that adds the helper script to generate the test suite, and another one that adds the test suites like:

feature: add ISO IEC 13818-4 MPEG2 test suites

@rsanchez87
Copy link
Contributor Author

This PR is adding new test suites to fluster, hence new features but none of your commits has a feature: type.

You should split build: compilation: add gen_mpeg2_video.py in the absence of raw file creation into 2 commits, one that adds the helper script to generate the test suite, and another one that adds the test suites like:

feature: add ISO IEC 13818-4 MPEG2 test suites

Perfect, I'll split it and leave it as you commented, thanks

@ylatuya
Copy link
Contributor

ylatuya commented Feb 6, 2025

The README must be updated as well

@rsanchez87
Copy link
Contributor Author

rsanchez87 commented Feb 6, 2025

The README must be updated as well

Yes, I know, the PR is still in Draft

@rsanchez87 rsanchez87 force-pushed the OCP-6154 branch 8 times, most recently from b1b2908 to 0e2d569 Compare February 7, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants