Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: V2 UI segments #3885

Merged
merged 10 commits into from
Feb 7, 2025
Merged

chore: V2 UI segments #3885

merged 10 commits into from
Feb 7, 2025

Conversation

markphelps
Copy link
Collaborator

@markphelps markphelps commented Feb 6, 2025

  • Implements basic CRUD for Segments/Constraints
  • Fixes segment selection for rules
  • Fixes rule re-ordering via DnD
  • Removes most of the *Base typescript types that are no longer necessary
  • Removes deprecated segmentKey field for rules/distributions in favor of segmentKeys
  • Removes deadcode

@markphelps markphelps requested a review from a team as a code owner February 6, 2025 19:26
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Feb 6, 2025
Signed-off-by: Mark Phelps <[email protected]>
@markphelps markphelps added the v2 For consideration for v2 of Flipt label Feb 6, 2025
Copy link
Member

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👌

@markphelps markphelps merged commit 912133a into v2 Feb 7, 2025
5 of 29 checks passed
@markphelps markphelps deleted the v2-ui-segments branch February 7, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XL This PR changes 500-999 lines, ignoring generated files. v2 For consideration for v2 of Flipt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants